Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to SelfConfiguration #52

Open
buckyroberts opened this issue Jan 19, 2021 · 0 comments
Open

Changes to SelfConfiguration #52

buckyroberts opened this issue Jan 19, 2021 · 0 comments
Assignees

Comments

@buckyroberts
Copy link
Collaborator

buckyroberts commented Jan 19, 2021

When making changes to SelfConfiguration, broadcast those changes to all known nodes. Banks also have to stream down those changes to users so that the Account Manager (and other clients) can update.

Nodes will send out signed PATCH requests when changes are made to the following fields.

Banks

  • account_number
  • default_transaction_fee
  • version

Validators

  • account_number
  • daily_confirmation_rate
  • default_transaction_fee
  • version

Notes

  • signed PATCH requests should also include modified_date to prevent malicious actors from rebroadcasting old data
  • if a request is received with a modified_date earlier than the one you have stored for that node, request should be ignored

Miscellaneous

  • nodes who aren’t connected don’t care about your changes
  • additionally if they want to connect later on then they will be fetching your updated config then anyways

Original notes for background/context - https://docs.google.com/document/d/1igRh6Zbz5_UhbNMRRtO7XGk9Yiuaf6Hj2-rHwsVzAoc/edit?usp=sharing

Changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants