Skip to content

Commit

Permalink
Added: Properly log or open browser to ipv6 address. Closes #553
Browse files Browse the repository at this point in the history
  • Loading branch information
[email protected] authored and [email protected] committed Feb 17, 2017
1 parent 04204d0 commit a21256d
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 5 deletions.
2 changes: 2 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

----------
### 0.2.203
Added: Properly log or open browser to ipv6 address. See [#553](https://github.com/theotherp/nzbhydra/issues/553).

Changed: Added option to keep "obfuscated" in NzbGeek titles. See [#553](https://github.com/theotherp/nzbhydra/issues/553).

Changed: Respect min/max age/size when provided in API calls. This is not specified in the newznab API standards but might be helpful for some. See [#551](https://github.com/theotherp/nzbhydra/issues/551).
Expand Down
13 changes: 11 additions & 2 deletions nzbhydra.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,23 @@ def run(arguments):
elif config.settings.main.httpProxy:
webaccess.set_proxies(config.settings.main.httpProxy, config.settings.main.httpsProxy)

logger.notice("Starting web app on %s:%d" % (host, port))

if config.settings.main.externalUrl is not None and config.settings.main.externalUrl != "":
f = furl(config.settings.main.externalUrl)
else:
f = furl()
f.host = "127.0.0.1" if config.settings.main.host == "0.0.0.0" else config.settings.main.host

if config.settings.main.host == "0.0.0.0":
f.host = "127.0.0.1"
elif config.settings.main.host == "::":
f.host = "[::1]"
elif ":" in config.settings.main.host:
f.host = "[%s]" % config.settings.main.host
else:
f.host = config.settings.main.host
f.port = port
f.scheme = "https" if config.settings.main.ssl else "http"
logger.notice("Starting web app on %s:%d" % (f.host, f.port))
if not arguments.nobrowser and config.settings.main.startupBrowser:
if arguments.restarted:
logger.info("Not opening the browser after restart")
Expand Down
2 changes: 1 addition & 1 deletion static/js/nzbhydra.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion static/js/nzbhydra.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ui-src/js/config-fields-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ function ConfigFields($injector) {
type: 'text',
label: 'Host',
required: true,
placeholder: 'IPv4 address to bind to',
placeholder: 'IPv4/6 address to bind to',
help: 'I strongly recommend using a reverse proxy instead of exposing this directly. Requires restart.'
},
validators: {
Expand Down

0 comments on commit a21256d

Please sign in to comment.