Some plugins break v6.0.0 beta-2

[moonysolari]

The Hub cannot load if some plugins are installed:

• Custom Mission Pack - Peacock Plugin, reported in https://discord.com/channels/826809653181808651/1059569859756818583/1073677901754552450
• The Sarajevo 6.

[moonysolari]

This bug is caused by the plugins. Both of the reported plugins add campaigns, and they do not correctly call the function to generate mission data. This function has type GenSingleMissionFunc, which takes two arguments: a contract ID and a game version. However, in both plugins, only a contract ID is passed.

This is not a result of API changes in v6 because the API existed before v5. The reason why this is only recently an issue is that the game version passed by this function has been unused before v6 introduced mastery data.

Since plugin developers tend to use each other's works as templates, it is likely that this problem will occur to other plugins which add campaigns.

Attached are related code snippets.

Custom Mission Pack plugin:

controller.hooks.contributeCampaigns.tap("CustomMissions-Campaign", (campaigns, gsmFunc, gsvFunc, gameVersion) => {
        if (RuddyCampaign.StoryData.length == 0) {
            contracts.forEach((mission) =>
                RuddyCampaign.StoryData.push(gsmFunc(mission.Metadata.Id))
            )
        }

TS6 plugin:

controller.hooks.contributeCampaigns.tap("TheSarajevoSix-Campaign", (campaigns, gsmFunc, gsvFunc, gameVersion) => {
        if (ts6Campaign.StoryData.length == 0) {
            ts6Missions.forEach((mission) =>
                // Should be ts6Campaign.StoryData.push(gsmFunc(mission.id, gameVersion))
                ts6Campaign.StoryData.push(gsmFunc(mission.id))
            )
        }

Peacock/components/controller.ts

Lines 354 to 360 in a297973

	contributeCampaigns: SyncHook<
	[
	/** campaigns */ Campaign[],
	/** genSingleMissionFunc */ GenSingleMissionFunc,
	/** genSingleVideoFunc */ GenSingleVideoFunc,
	/** gameVersion */ GameVersion,
	]

Peacock/components/types/types.ts

Lines 1266 to 1269 in a297973

	export type GenSingleMissionFunc = (
	contractId: string,
	gameVersion: GameVersion,
	) => ICampaignMission

[moonysolari]

@AnthonyFuller