Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test artifact caching #181

Open
jku opened this issue Aug 28, 2024 · 2 comments
Open

test artifact caching #181

jku opened this issue Aug 28, 2024 · 2 comments

Comments

@jku
Copy link
Member

jku commented Aug 28, 2024

from @segiddins: we should test artifact caching.

This is a bit tricky since I'm not sure we can assume that the TARGET_DIR we define for the test suite is the actual application cache -- this means we likely can't do the real test of "if we maliciously modify the cached artifact, will client re-download?"

That said, we could at least check that client does cache artifacts:

  • modify CLIENT-CLI.md so it mentions that download_target() must use an artifact cache
  • make sure the embedded clients actually use cache
  • in the tests, do two download_target() calls in a row and expect the client to only download once
@jku jku changed the title test caching test artifact caching Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jku and others