Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropinstance() missing? #30

Closed
sido420 opened this issue Aug 14, 2018 · 2 comments · Fixed by #36
Closed

dropinstance() missing? #30

sido420 opened this issue Aug 14, 2018 · 2 comments · Fixed by #36

Comments

@sido420
Copy link

sido420 commented Aug 14, 2018

Is dropInstance not implemented for this driver? Why?
@thgreasi
Copy link
Owner

Yea, that's true, I haven't updated this driver since the release of LF v1.6 (which added the dropInstance() method).
Will add this in my todo list.

thgreasi added a commit that referenced this issue Apr 29, 2019
@thgreasi
Inherit all non _ prefixed methods
f561ef0 
Resolves #30
thgreasi added a commit that referenced this issue Apr 29, 2019
@thgreasi
Inherit all non _ prefixed methods
063431a 
Resolves #30
@thgreasi thgreasi mentioned this issue Apr 30, 2019
Merged
@thgreasi
Copy link
Owner

@sido420 PR #36 should be addressing this. It would be great if you could give this a try on a realistic app and share your feedback.

thgreasi added a commit that referenced this issue May 18, 2019
@thgreasi
Add dropInstance method
7a4ac27 
Resolves #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dropInstance method thgreasi/localForage-cordovaSQLiteDriver
2 participants
@thgreasi @sido420