Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create at least one test for ant modules without any tests #116

Closed
ursjoss opened this issue Mar 7, 2023 · 0 comments · Fixed by #123
Closed

Create at least one test for ant modules without any tests #116

ursjoss opened this issue Mar 7, 2023 · 0 comments · Fixed by #123
Labels

Comments

@ursjoss
Copy link
Collaborator

ursjoss commented Mar 7, 2023

Some modules don't have any test. While compiling the project, there are warnings about this, e.g.

No such dir /home/urs/work/git/forked/tr-pc/modules/au.com.trgtd.tr.imports/test/unit/src; should not define test deps

The missing tests can easily be observed in Netbeans, as there is no node Unit Test Packages in the Project tree:
image

Also (at least some) of those modules are not included in the just recipe verify-tr (which is run by the CI via Github Actions). They should be listed further down commented out as of line #97:

image

We should ensure that evrey module has at least one unit test, even if it is just a dummy test that let's us avoid the warning and most of all include the module in the ci test run. Otherwise we may add real tests later and forget to activate the module in the justfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants