Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac installer - ensure clear steps after JRE removal #38

Open
RadekCap opened this issue Dec 23, 2022 · 2 comments
Open

Mac installer - ensure clear steps after JRE removal #38

RadekCap opened this issue Dec 23, 2022 · 2 comments
Labels
mac ThinkingRock on Mac

Comments

@RadekCap
Copy link
Collaborator

JRE was bundled automatically in the Mac installer. We removed it because of security concerns about ant-contrib discussed in #35

We need to ensure that there won't be any obstacles for Mac users. Document it, bundle it or find better solutions.
ursjoss pushed a commit that referenced this issue Dec 23, 2022
@RadekCap
Removed ant-contrib and JRE bundling (#41)
c6dc9c8 
Removes the dependency on ant-contrib-0.6.jar by temporarily
removing the option of bundling the jre for MacOS. How to solve
this in the long run will be decided in the scope of ticket #38.
@ursjoss ursjoss added the mac ThinkingRock on Mac label Jan 24, 2023
@degrown degrown mentioned this issue Feb 7, 2023
Closed
@degrown
Copy link
Contributor

degrown commented Feb 7, 2023

My thoughts to make the bugs/app more reproducible and simple are:

  • bundle a JRE version also for macOS
  • make working the app only with the bundled JRE version

I know that in the existing version we have the choice to download a version that uses (or not) the bundled JRE. But I'm asking:

  • does is this useful yet?
  • will we have the bandwidth to support/triage different flavours of JDK?
  • does that give us something more to the users?

What do you think?

@RadekCap
Copy link
Collaborator Author

RadekCap commented Feb 8, 2023

My thoughts to make the bugs/app more reproducible and simple are:

  • bundle a JRE version also for macOS

I would bundle it not just for the Mac, but for all platforms. It's currently popular solution of solving dependency on runtime and related issues.

  • make working the app only with the bundled JRE version

Why this? We can't hardly expect that someone will update configuration to run on a different version of java. If yes it's just an unsupported scenario.

I know that in the existing version we have the choice to download a version that uses (or not) the bundled JRE. But I'm asking:

  • does is this useful yet?
  • will we have the bandwidth to support/triage different flavours of JDK?

Currently I don't see enough power but this possibility could be changed later if needed.

  • does that give us something more to the users?

I don't think so.

What do you think?

@ursjoss ursjoss mentioned this issue Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mac ThinkingRock on Mac
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ursjoss @RadekCap @degrown