Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should our delete_file and delete_bucket functions return True on success? #30

Open
thomasborgen opened this issue Jun 4, 2020 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@thomasborgen
Copy link
Owner

its a good question, we used to have some of these return True, but the google library returns None, and we do too since as long as there are no exception raised its 100% deleted. Also because it will never return False its not really a boolean return value.

@ChameleonTartu
What do you think?

@thomasborgen thomasborgen added the question Further information is requested label Jun 4, 2020
@ChameleonTartu
Copy link
Collaborator

@thomasborgen I think you are right. There is no need in True if we don't have false. In the meantime, should we document this behaviour in the docstrings?

The confusing part with None from my perspective, person who uses code wouldn't know if a function is sync/async, so None in this case may mean success or function may continue doing its job. Do you sync async is a valid point here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants