Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing HTTP error handling #25

Open
TheHalcyonSavant opened this issue Jan 19, 2016 · 5 comments
Open

Missing HTTP error handling #25

TheHalcyonSavant opened this issue Jan 19, 2016 · 5 comments

Comments

@TheHalcyonSavant
Copy link

I can't find the superagent error callback, it seems it's forgotten the usage of err parameter here. Do you accept PR for this?

@alebell
Copy link

alebell commented Mar 7, 2016

I wanted to report this too. It would be great if the error handling could be implemented properly.

@callumacrae
Copy link
Collaborator

A PR would be good! 😄

@backflip
Copy link

Would you prefer changing the API to expect callback: function(err, res) or keep callback: function(res) and let the consumer check whether res is of type Error?

@backflip
Copy link

backflip commented Dec 7, 2016

@callumacrae, which approach would you prefer?

@jhermsmeier
Copy link
Collaborator

jhermsmeier commented Jun 6, 2017

HTTP request error handling has been added in #32 (published as 0.3.1) – the callback will get an error as its first argument, i.e. callback: function(error, res) now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants