-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing HTTP error handling #25
Comments
I wanted to report this too. It would be great if the error handling could be implemented properly. |
A PR would be good! 😄 |
Would you prefer changing the API to expect |
@callumacrae, which approach would you prefer? |
HTTP request error handling has been added in #32 (published as 0.3.1) – the callback will get an error as its first argument, i.e. |
I can't find the superagent error callback, it seems it's forgotten the usage of
err
parameter here. Do you accept PR for this?The text was updated successfully, but these errors were encountered: