Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonise licence parsing (Figshare/Zenodo) #37

Open
rhigman opened this issue Jun 11, 2024 · 0 comments
Open

Commonise licence parsing (Figshare/Zenodo) #37

rhigman opened this issue Jun 11, 2024 · 0 comments

Comments

@rhigman
Copy link
Member

rhigman commented Jun 11, 2024

Both fsuploader and zenodouploader use regex to normalise the work licence retrieved from Thoth before trying to match it against the licence options provided by the target platform. The matching logic and expression used in each module are slightly different. Investigate whether they could be commonised.

  • The Zenodo expression is more thorough about removing non-distinctive CC suffixes (/deed, /legalcode) from the licence URL. It would be beneficial to replicate this for the Figshare check.
  • Be aware that pre-4.0 CC licences may have per-country variants represented by suffixes which are distinctive (e.g. /us, /br).
    • At the moment, for a Figshare repository whose licence list contained e.g. by/3.0/us but not by/3.0 (unlikely but possible), a false positive match would be returned for a Thoth by/3.0 licence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant