Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May have to rethink the way we grouped tests #49

Open
johntdyer opened this issue Apr 10, 2020 · 2 comments
Open

May have to rethink the way we grouped tests #49

johntdyer opened this issue Apr 10, 2020 · 2 comments

Comments

@johntdyer
Copy link
Contributor

So today I was working on Labels and it turns out Labels can have Tests in its struct. Thats great however I am not sure how do that that since we have no top level Test type in the app... All tests actually should be part of this struct but I am not sure my Go is strong enough to know how to do that effectivly, since the tests struct would have to allow for a list of varying types ( ftp_server, dns_server, ect ect... ).. Do you have any strong opinions here ?

Also are you on Webex Teams or Discord by any chance ? or maybe we can setup Gitter for this repo to discuss?

@william20111
Copy link
Contributor

Gitter seems like a good idea, had never heard of it but looks easy to drop in and out of for coversation.

My first thought here would be a Test interface with Create, Update, Delete on it? Can update current tests to support that when we refactor the layout?

@william20111
Copy link
Contributor

https://github.com/william20111/go-thousandeyes/blob/master/README.md

Updated with gitter group on readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants