Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should onError be an async function? #91

Open
third774 opened this issue Sep 28, 2024 · 2 comments
Open

Should onError be an async function? #91

third774 opened this issue Sep 28, 2024 · 2 comments

Comments

@third774
Copy link
Collaborator

Just ran into an issue where I found myself wanting onError to be async so I could use an await in there.

https://github.com/threepointone/partyserver/blob/main/packages/partyserver/src/index.ts#L524

Does this seem reasonable, and if so hopefully it's not a big change?

@threepointone
Copy link
Owner

yeah it should be doable, but go on, what was your usecase

@third774
Copy link
Collaborator Author

Ah, just doing some logging, but in order to capture the log information I need to grab a value from storage (a meeting id for correlating logs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants