Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] 关于Metric的special token #441

Open
hzhwcmhf opened this issue Jul 5, 2020 · 0 comments
Open

[Maintenance] 关于Metric的special token #441

hzhwcmhf opened this issue Jul 5, 2020 · 0 comments
Labels
maintenance Maintain existing code new New issue

Comments

@hzhwcmhf
Copy link
Member

hzhwcmhf commented Jul 5, 2020

metric应改用convert_ids_to_tokens或convert_ids_to_sent系列的函数。和原来的区别在于,输入可以选择性的带<eos>等special token,也可以不带。可以带。

  • 检查实现,是否有没用convert系列函数的情况
  • 检查文档,应在文档中说明special token的处理方式
  • 应在example中有所体现
  • 原有Test应该能够通过

涉及的Metric有:

precision_recall:92 需要修改
293-297 检查一下,默认参数是remove special 所以感觉没有错

@hzhwcmhf hzhwcmhf added new New issue maintenance Maintain existing code labels Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintain existing code new New issue
Projects
None yet
Development

No branches or pull requests

1 participant