Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular Google Play Services dependencies #13

Open
uerceg opened this issue Jul 16, 2018 · 0 comments
Open

More granular Google Play Services dependencies #13

uerceg opened this issue Jul 16, 2018 · 0 comments

Comments

@uerceg
Copy link

uerceg commented Jul 16, 2018

Hey guys.

First I would like to thank you for making this module, was quite anticipated by some of us, since now it frees us from having Google Play Services JAR as direct dependency in modules we write. Never the less, wanted to check this with you. When using your module, I see that following things are being added to the app in dexer phase:

build/android/intermediates/exploded-aar/play-services-ads-lite-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-analytics-impl-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-appinvite-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-auth-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-auth-base-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-awareness-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-base-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-basement-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-cast-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-cast-framework-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-gcm-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-identity-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-iid-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-location-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-maps-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-nearby-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-tasks-11.0.4/classes.jar" 
build/android/intermediates/exploded-aar/play-services-wallet-11.0.4/classes.jar"

I might be only interested in adding -basement module to my plugin and the rest is of no interest to me. By advising client to add your current module, method count will get quite increased and might breach 65K limit for some. With that in mind:

I was wondering if there are any plans to build support for adding separate modules as dependencies?

So something which can be added to user's tiapp.xml like this:

<module platform="android">ti.playservices.basement</module>

?

Thanks in advance for your reply.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant