Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check_workflow_size argument to the control functions #914

Open
topepo opened this issue Jun 24, 2024 · 2 comments
Open

Add a check_workflow_size argument to the control functions #914

topepo opened this issue Jun 24, 2024 · 2 comments

Comments

@topepo
Copy link
Member

topepo commented Jun 24, 2024

This check can be a little annoying and we have an arbitrary cutoff. This would make an argument for the cutoff.

@simonpcouch
Copy link
Contributor

I would make the argument here that, since the user has explicitly chosen with a non-default argument setting save_workflow = TRUE to store that object, we ought not to warn at all, as we don't with save_pred = TRUE

@topepo
Copy link
Member Author

topepo commented Jun 24, 2024

I mostly agree. People might not realize that their workflow is huge (for some value of huge) but that should be relatively rare. If we keep it, we should bump the threshold up by a log unit or two.

The problem that sparked this was that simulated annealing needs the workflow and, when it calls tune_grid(), it sets save_workflow = TRUE even if the opposite was done in control_sim_anneal().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants