Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate example objects #717

Merged
merged 2 commits into from
Sep 8, 2023
Merged

regenerate example objects #717

merged 2 commits into from
Sep 8, 2023

Conversation

simonpcouch
Copy link
Contributor

In order to add tests for a fix for #715, I needed to regenerate the example test objects, but there were a few unrelated failures that needed test changes. I figured I'd PR the example object and test changes using main tune first and then follow up with only the needed changes for #715. :)

A whole lot of:

→ A | warning: prediction from a rank-deficient fit may be misleading
→ B | warning: some 'x' values beyond boundary knots may cause ill-conditioned bases

when regenerating the test objects.🥴

Copy link
Contributor Author

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these were last updated in Oct 2020.

tests/testthat/_snaps/bootci.md Show resolved Hide resolved
tests/testthat/test-autoplot.R Show resolved Hide resolved
tests/testthat/_snaps/select_best.md Show resolved Hide resolved
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Thanks for attaching all the receipts for the changes! And I am GLAD these finally get updated 🥳

@simonpcouch simonpcouch merged commit 9571f05 into main Sep 8, 2023
9 checks passed
@simonpcouch simonpcouch deleted the prep-for-fix-715 branch September 8, 2023 14:52
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants