Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub-second value parsing accurately #128

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Nov 14, 2024

Fix #127

Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down! Just curious, what's the rationale of removing parse_time()?

@eitsupi
Copy link
Contributor Author

eitsupi commented Nov 14, 2024

what's the rationale of removing parse_time()?

There was no particular intent; I fixed it in the way that parse_time() was rewritten.

As an aside, I think this function is worth exporting in a follow-up PR.

@eitsupi
Copy link
Contributor Author

eitsupi commented Nov 17, 2024

@krlmlr Could you check this?

@krlmlr krlmlr added this pull request to the merge queue Nov 18, 2024
@krlmlr
Copy link
Member

krlmlr commented Nov 18, 2024

Thanks! The check might be prone to floating-point errors, we'll see.

Merged via the queue into tidyverse:main with commit 4b06c80 Nov 18, 2024
16 checks passed
@eitsupi eitsupi deleted the support-sub-second branch November 18, 2024 03:14
@eitsupi
Copy link
Contributor Author

eitsupi commented Nov 18, 2024

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse_hms() cannot convert sub-second time accurately
2 participants