Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nebula_examples): add ament_lint dependencies #65

Closed
wants to merge 2 commits into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 31, 2023

PR Type

  • Bug Fix

Related Links

Description

ament_lint is called from CMakeLists.txt but it's not declared as a dependency in package.xml, this PR addresses that.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@esteve
Copy link
Contributor Author

esteve commented Aug 31, 2023

@amc-nu ping 🙂

@esteve
Copy link
Contributor Author

esteve commented Sep 5, 2023

Closing. Superseded by #67

@esteve esteve closed this Sep 5, 2023
@esteve esteve deleted the add-ament-lint-deps branch September 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants