From 8c61382f7a1e414ebb4f679db67d97c85ba156bc Mon Sep 17 00:00:00 2001 From: Alan West <3676547+alanwest@users.noreply.github.com> Date: Wed, 24 Apr 2024 08:22:57 -0700 Subject: [PATCH] Make exemplar default language normative (#4009) I'm making my best guess of what was intended. If the language should use `SHOULD` or `MAY` please comment. --- specification/metrics/sdk.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 4c50c4d8428..9c9a48bd85b 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -1105,13 +1105,13 @@ The SDK MUST include two types of built-in exemplar reservoirs: By default: -- Explicit bucket histogram aggregation with more than 1 bucket will +- Explicit bucket histogram aggregation with more than 1 bucket SHOULD use `AlignedHistogramBucketExemplarReservoir`. - Base2 Exponential Histogram Aggregation SHOULD use a `SimpleFixedSizeExemplarReservoir` with a reservoir equal to the smaller of the maximum number of buckets configured on the aggregation or twenty (e.g. `min(20, max_buckets)`). -- All other aggregations will use `SimpleFixedSizeExemplarReservoir`. +- All other aggregations SHOULD use `SimpleFixedSizeExemplarReservoir`. Exemplar default reservoirs MAY change in a [minor version bump](./../versioning-and-stability.md#minor-version-bump). No