-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add printing service in chromium-vm and bussiness-vm #783
base: main
Are you sure you want to change the base?
Conversation
I'd suppose to add some sort of icon/shortcut for "Enter localhost:631 into the browser (Use Ctrl+N in business-vm before)" -- otherwise user will not be able to manage printing. A bookmark in a browser bookmark bar as a hotfix? |
@@ -99,6 +99,13 @@ in | |||
# Set default PDF XDG handler | |||
xdg.mime.defaultApplications."application/pdf" = "ghaf-pdf.desktop"; | |||
|
|||
services.printing.enable = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible we have one CUPS server only, have that in something like a peripherals-vm. Then app VMs just setup CUPS as client: https://www.cups.org/doc/man-client.conf.html
@@ -85,6 +85,11 @@ let | |||
firewall.allowedTCPPorts = [ 53 ]; | |||
firewall.allowedUDPPorts = [ 53 ]; | |||
}; | |||
services.avahi = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to have three avahi daemons running on this system? I am also a bit worried about reflect setting in terms of security impact, NixOS option states:
Reflect incoming mDNS requests to all allowed network interfaces.
I tested this PR with all builds of nvidia-agx and nvidia-nx (both cross compile and remote builder) and succeeded in the builds where our system that tests our PRs seem to have a problem of building. |
Tested on Lenovo-X1( I tested with HP Laserjet M15w and with Canon ir-adv c3822. Issues:
Working:
Note: I did not run the automated tests yet. This pr will need to be retested after printing pdf files has been solved. |
I added CUPS into Zathura VM too to solve the issue quickly. It can only be used with driverless printers detected automatically but it will be solved in the future with unified printing service. Storage VM configurations added. Manage button redirects to distro settings and we don't have a settings UI yet as far I know. I checked quickly how to manage the button but I don't have a solution yet. |
Printing with office printers in Finland & UAE has been confirmed to be working from browser (thanks @jkuro-tii) Driverless printing does not work in the offices sadly, so there will need to be another solution for that. The manage button is probably not that important. If there is no easy solution, I think it is fine to leave it as it is. Printer information is now saved between boots. Thanks also for changing the bookmark name to "Printing". |
CUPS is enabled in zathura-vm, chromium-vm and bussines-vm CUPS overlay is applied due to printer webpage bug. Avahi service reflection is added in net-vm. CUPS web page is added into default chromium bookmarks. Signed-off-by: Berk Arslan <[email protected]>
Description of changes
CUPS and Avahi sercvie are enabled in chromium-vm and bussines-vm.
Avahi service reflection is added into net-vm.
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
Driverless printers doesn't need to be added to printer, otherwise;
localhost:631
into the chromium and trusted browsers