-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support failpoints group #55
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: TXXT <[email protected]>
Signed-off-by: TXXT <[email protected]>
I think all the tests need to be updated, It is better to test in the form of |
@BusyJay I think this PR is ready PTAL |
08942e2
to
86f06ca
Compare
Signed-off-by: TXXT <[email protected]>
Signed-off-by: TXXT <[email protected]>
@NingLin-P PTAL |
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to use the patch inside TiKV if the interfaces are good enough to write clean code. As far as what I can see, it's hard to build thread group without a FailPointRegistry::current
method.
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
This PR is staled for about a week |
So have you tried to use it in TiKV? Is everything working well? |
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Signed-off-by: Xintao <[email protected]>
Let multiple tests run over different threads, meanwhile each configuration doesn't affect others.
FailPointRegistry
as local registry.pub fn create_registry() -> FailPointRegistry
can get a newFailPointRegistry
. So we can bound threads into exact one registry withregister_current(&self)
andderegister_current(&self)
.close #51