Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't attempt to reuse in foreground thread #224

Merged
merged 3 commits into from
Jun 22, 2024
Merged

fix: don't attempt to reuse in foreground thread #224

merged 3 commits into from
Jun 22, 2024

Conversation

andylokandy
Copy link
Collaborator

Signed-off-by: andylokandy [email protected]

@andylokandy andylokandy requested a review from zhongzc June 21, 2024 14:52
@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9615582884

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 79.228%
Totals Coverage Status
Change from base Build 9529311740: 0.09%
Covered Lines: 1724
Relevant Lines: 2176
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9615687438

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 79.228%
Totals Coverage Status
Change from base Build 9529311740: 0.09%
Covered Lines: 1724
Relevant Lines: 2176
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9615690330

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 79.228%
Totals Coverage Status
Change from base Build 9529311740: 0.09%
Covered Lines: 1724
Relevant Lines: 2176
💛 - Coveralls

@andylokandy andylokandy merged commit eb84d3d into tikv:master Jun 22, 2024
9 checks passed
@MrCroxx MrCroxx mentioned this pull request Jun 22, 2024
Merged
3 tasks
MrCroxx
MrCroxx reviewed Jun 22, 2024
View reviewed changes
Copy link
Member

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andylokandy . It really helps a lot! 🙏

foyer-rs/foyer#571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCroxx MrCroxx MrCroxx left review comments

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andylokandy @coveralls @MrCroxx @zhongzc