-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule-checker does not consider the engine label constraint #6662
Labels
affects-7.1
This bug affects the 7.1.x(LTS) versions.
severity/critical
type/bug
The issue is confirmed as a bug.
Comments
JmPotato
added
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.2
and removed
may-affects-5.1
may-affects-5.2
may-affects-5.3
may-affects-5.4
may-affects-6.1
may-affects-6.5
may-affects-7.1
labels
Jun 24, 2023
This was referenced Jun 24, 2023
JmPotato
removed
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.2
labels
Jun 25, 2023
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 25, 2023
…#6660) close #6662 Signed-off-by: Ryan Leung <[email protected]>
rleungx
added
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
labels
Jul 10, 2023
rleungx
added a commit
to rleungx/pd
that referenced
this issue
Jul 10, 2023
…tikv#6660) close tikv#6662 Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jul 10, 2023
…#6660) (#6778) close #6662 Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Aug 14, 2023
close tikv#6662 Signed-off-by: ti-chi-bot <[email protected]>
We don't need to pick this fix to release-6.5 since it doesn't support survival preference in the placement rule in SQL. |
rleungx
removed
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
labels
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-7.1
This bug affects the 7.1.x(LTS) versions.
severity/critical
type/bug
The issue is confirmed as a bug.
Bug Report
#6633 broke the constrain that we can only move peer between the stores that satisfy the rule, as a result,
rule-checker
will move the learner peer away to a TiKV store while keep adding rule peer in the TiFlash stores. This will cause a TiFlash replica of a region never to be replicated well while bringing many redundant replicas to other TiKV nodes.In monitoring, its phenomenon may be as shown in the figure above, with a large number of
add-rule-peer
andmove-to-better-location
at the same time. And in the log, you can see that the two act in the same region successively.The text was updated successfully, but these errors were encountered: