Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule-checker does not consider the engine label constraint #6662

Closed
JmPotato opened this issue Jun 24, 2023 · 1 comment · Fixed by #6660
Closed

rule-checker does not consider the engine label constraint #6662

JmPotato opened this issue Jun 24, 2023 · 1 comment · Fixed by #6660
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/critical type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

JmPotato commented Jun 24, 2023

Bug Report

#6633 broke the constrain that we can only move peer between the stores that satisfy the rule, as a result, rule-checker will move the learner peer away to a TiKV store while keep adding rule peer in the TiFlash stores. This will cause a TiFlash replica of a region never to be replicated well while bringing many redundant replicas to other TiKV nodes.

b4e2acdf-68ad-42b4-86e8-540e759e45b9

In monitoring, its phenomenon may be as shown in the figure above, with a large number of add-rule-peer and move-to-better-location at the same time. And in the log, you can see that the two act in the same region successively.

@rleungx rleungx reopened this Jul 10, 2023
@rleungx rleungx added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jul 10, 2023
rleungx added a commit to rleungx/pd that referenced this issue Jul 10, 2023
@nolouch nolouch closed this as completed Jul 10, 2023
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Aug 14, 2023
@rleungx
Copy link
Member

rleungx commented Aug 14, 2023

We don't need to pick this fix to release-6.5 since it doesn't support survival preference in the placement rule in SQL.

@rleungx rleungx removed affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Aug 14, 2023
@ti-chi-bot ti-chi-bot added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants