New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scatter might have a skewed distribution if the operators fails #7838

Open

rleungx opened this issue Feb 22, 2024 · 0 comments

Labels

type/enhancement

Member

rleungx commented Feb 22, 2024

Enhancement Task

We use a TTL cache to calculate the distribution of scatter, see

pd/pkg/schedule/scatter/region_scatterer.go

Line 68 in d6d9fea

    
           groupDistribution *cache.TTLString // value type: map[uint64]uint64, group -> StoreID -> count

But if the operator is created but fails, the cache won't be changed. If the client retries, it might have a skewed distribution.

rleungx added the type/enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment