Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the PD log level through "kubectl edit tc" or "tiup cluster edit-config" has no effect #8117

Closed
mayjiang0203 opened this issue Apr 23, 2024 · 3 comments · Fixed by #8118
Closed

Changing the PD log level through "kubectl edit tc" or "tiup cluster edit-config" has no effect #8117

mayjiang0203 opened this issue Apr 23, 2024 · 3 comments · Fixed by #8118
Assignees
@rleungx
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@mayjiang0203
Copy link

Bug Report

What did you do?

What did you expect to see?

log level can be reset after modifying.

What did you see instead?

pd instance restarts, but the log level hasn't been reset.
image

What version of PD are you using (pd-server -V)?

v8.1.0
@mayjiang0203 mayjiang0203 added the type/bug The issue is confirmed as a bug. label Apr 23, 2024
@rleungx rleungx mentioned this issue Apr 23, 2024
Merged
@mayjiang0203
Copy link
Author

mayjiang0203 commented Apr 23, 2024 •
edited
Loading

/remove-severity moderate
/severity major
w/a: https://docs.pingcap.com/tidb/stable/dynamic-config#modify-pd-configuration-dynamically
set config pd log.level='info'
/assign @rleungx
/label affects-8.1

@mayjiang0203
Copy link
Author

/remove-label may-affects-5.4
/remove-label may-affects-6.1
/remove-label may-affects-6.5
/remove-label affects-7.1
/remove-label affects-7.5

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

@mayjiang0203: These labels are not set on the issue: affects-7.1, affects-7.5.

In response to this:

/remove-label may-affects-5.4
/remove-label may-affects-6.1
/remove-label may-affects-6.5
/remove-label affects-7.1
/remove-label affects-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx rleungx added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. and removed may-affects-7.5 may-affects-7.1 labels Apr 23, 2024
ti-chi-bot bot added a commit that referenced this issue Apr 25, 2024
@rleungx @ti-chi-bot
*: fix log level (#8118)
de5bad3 
close #8117

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
nolouch pushed a commit to nolouch/pd that referenced this issue Apr 29, 2024
@rleungx @ti-chi-bot @nolouch
*: fix log level (tikv#8118)
f26d578 
close tikv#8117

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue May 8, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8118
db7175c 
close tikv#8117

Signed-off-by: ti-chi-bot <[email protected]>
This was referenced May 8, 2024
Merged
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue May 8, 2024
@ti-chi-bot @rleungx @ti-chi-bot
*: fix log level (#8118) (#8149)
27fbf10 
close #8117

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue May 20, 2024
@ti-chi-bot @rleungx @ti-chi-bot
*: fix log level (#8118) (#8151)
00487a4 
close #8117

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue Jul 31, 2024
@ti-chi-bot @rleungx @ti-chi-bot
*: fix log level (#8118) (#8150)
22b38ab 
close #8117

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rleungx rleungx

Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix log level rleungx/pd
2 participants
@mayjiang0203 @rleungx