Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evict-leader-scheduler dosen't work when creating it with the same store-id repeatedly #8756

Closed
okJiang opened this issue Oct 31, 2024 · 3 comments · Fixed by #8757
Closed

Evict-leader-scheduler dosen't work when creating it with the same store-id repeatedly #8756

okJiang opened this issue Oct 31, 2024 · 3 comments · Fixed by #8757
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.

Comments

@okJiang
Copy link
Member

okJiang commented Oct 31, 2024

Bug Report

What did you do?

create evict-leader-scheduler with the same store-id repeatly

What did you expect to see?

  • it works well

What did you see instead?

  • balance-leader-scheduler conflict with evict-leader-scheduler

What version of PD are you using (pd-server -V)?
@okJiang okJiang added the type/bug The issue is confirmed as a bug. label Oct 31, 2024
@okJiang
Copy link
Member Author

okJiang commented Oct 31, 2024

/type bug
/severity major

@okJiang
Copy link
Member Author

okJiang commented Oct 31, 2024

This issue affects <8.3

This was referenced Oct 31, 2024
Merged
Merged
@okJiang okJiang changed the title Evict-leader-scheduler doen't work when create it with the same store-id repeatly Evict-leader-scheduler doen't work when creating it with the same store-id repeatedly Nov 1, 2024
@okJiang okJiang changed the title Evict-leader-scheduler doen't work when creating it with the same store-id repeatedly Evict-leader-scheduler dosen't work when creating it with the same store-id repeatedly Nov 1, 2024
@ti-chi-bot ti-chi-bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. report/customer Customers have encountered this bug. and removed may-affects-8.1 may-affects-7.1 may-affects-6.5 may-affects-7.5 affects-8.5 This bug affects the 8.5.x(LTS) versions. labels Nov 4, 2024
@rleungx rleungx added affects-6.1 This bug affects the 6.1.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 labels Nov 5, 2024
ti-chi-bot bot added a commit that referenced this issue Nov 5, 2024
@okJiang @ti-chi-bot
scheduler: use right check for evict/grant leader scheduler (#8758)
10e4889 
ref #8756

Signed-off-by: okJiang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 5, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 5, 2024
@ti-chi-bot @okJiang
scheduler: use right check for evict/grant leader scheduler (#8758) (#…
a385ada 
…8773)

ref #8756

Signed-off-by: okJiang <[email protected]>

Co-authored-by: okJiang <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 6, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8758
7170cc4 
ref tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 6, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 6, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8758
c750c8f 
ref tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 6, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 7, 2024
@ti-chi-bot @okJiang
scheduler: use right check for evict/grant leader scheduler (#8758) (#…
f235847 
…8779)

ref #8756

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: okJiang <[email protected]>

Co-authored-by: okJiang <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Nov 7, 2024
@ti-chi-bot @okJiang
scheduler: use right check for evict/grant leader scheduler (#8758) (#…
7fe011a 
…8778)

ref #8756

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: okJiang <[email protected]>

Co-authored-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Nov 21, 2024

this issue is fixed

@okJiang okJiang closed this as completed Nov 21, 2024
ti-chi-bot bot added a commit that referenced this issue Nov 21, 2024
@okJiang @ti-chi-bot
scheduler: add test for creating evict-leader-scheduler twice (#8757)
90cc61b 
close #8756

Signed-off-by: okJiang <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 21, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8757
9f97680 
close tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2024
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 21, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8757
138cb94 
close tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2024
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 21, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8757
d55e380 
close tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2024
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 21, 2024
@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8757
4033f6e 
close tikv#8756

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2024
Closed
@lhy1024 lhy1024 mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scheduler: add test for creating evict-leader-scheduler twice okJiang/pd
3 participants
@okJiang @rleungx @ti-chi-bot