Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo +nightly clippy --all --all-features --all-targets -- -D clippy::all error #235

Open
jiangshifu opened this issue Jul 8, 2022 · 2 comments
Open

cargo +nightly clippy --all --all-features --all-targets -- -D clippy::all error #235

jiangshifu opened this issue Jul 8, 2022 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jiangshifu
Copy link

image

commit 7a436ea (HEAD -> master, origin/master, origin/HEAD)
Author: Xinye Tao [email protected]
Date: Tue Jun 28 14:09:49 2022 +0800

support supplying file system to run ctl command (#231)

Signed-off-by: tabokie <[email protected]>

cat /etc/centos-release
CentOS Stream release 8
@tabokie
Copy link
Member

tabokie commented Jul 9, 2022

To avoid constantly rebuilding the cache, we use a specific nightly toolchain in our CI. That's why these issues are not caught early:

raft-engine/.github/workflows/rust.yml

Line 22 in 7a436ea

toolchain: nightly-2022-05-01

Feel free to fix these issues, and upgrade CI toolchain as well.

@tabokie tabokie added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 12, 2022
@tabokie tabokie mentioned this issue Jul 15, 2022
Merged
@tabokie
Copy link
Member

tabokie commented Jul 15, 2022

To be future-proof, I'll keep the issue here even though #244 will fix it temporarily. Contributions are always welcome if you find the CI toolchain is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tabokie @jiangshifu