Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT and unit tests are duplicating themselves and not correctly placed #546

Open
krzyk opened this issue Mar 15, 2019 · 1 comment
Open

Comments

@krzyk
Copy link
Contributor

krzyk commented Mar 15, 2019

  • test_floors is duplicating it_test_floors and more over test_floors is NOT a unit test (that is it uses client.get)
  • view.crudeapi.test_comment again duplicates it_test_comments (and is not a unit test, not to mention strange package)
  • view.table_shapes.test_table_shapes - same as above (should be moved to it_test_table_shapes)
  • view.tables.test_tables - same as above (should be it_test_tables)
  • view.item.test_items - should be renamed to it_test_items (and moved to integration tests) - and
  • view.crudapi.test_crud_api - is not a unit tests, should be moved to it_test_crud_api
  • test_poster - also looks like integration test, not unit one
  • test_sms - also not a unit test
@0crat
Copy link

0crat commented Mar 15, 2019

@emilianodellacasa/z please, pay attention to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants