Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax lint checks on autogenerated protobuf packages #23

Open
tstromberg opened this issue Sep 30, 2021 · 2 comments
Open

Relax lint checks on autogenerated protobuf packages #23

tstromberg opened this issue Sep 30, 2021 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

This was raised by a comment from @displague

Off the top of my head, the only linter I can think that this might impact is the gofumpt checker.

@mmlb
Copy link
Contributor

mmlb commented Oct 1, 2021

I lean towards not doing this. I'd rather have the go:generate step run goimports/gofumpt. I find it easier to avoid snowflakes.

@displague
Copy link
Member

displague commented Oct 4, 2021

If the make tasks (fmt,fix,gen?) do the right thing, and the contributing guides say as much, I don't think we would need to bog down the Go generator process or reduce the linter levels.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants