Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what to do when a repo needs an override? #44

Open
mmlb opened this issue May 4, 2022 · 0 comments
Open

what to do when a repo needs an override? #44

mmlb opened this issue May 4, 2022 · 0 comments
Labels
triage/discuss Indicates a PR or issue that requires discussion

Comments

@mmlb
Copy link
Contributor

mmlb commented May 4, 2022

I've tried to use lint-install's .golangci.yml file but it doesn't work for the tinkerbell/tink repo as is. We need to add an extra exclusion due to kubebuilder, see https://github.com/tinkerbell/tink/blob/main/.golangci.yml#L191-L193. I can think of 2 options.

  1. Add the exclusion to lint-install, every project will now share the config.
  2. Add a way for the project to have a .golangci.local.yml that lint-install merges with it's embedded file.

Option 1 upholds the one-way-to-do-things we currently want lint-install to enforce, but there might be some wiggle room for some things ... maybe.

Option 2 provides an escape hatch that if left unchecked can go against the very reason lint-install exists to begin with. Maybe instead of full merge lint-install will only merge from local if the embedded file doesn't already have that linter configured? This way local files can't override config of lint-install.

Thoughts @nshalman @tstromberg ?

@mmlb mmlb added the triage/discuss Indicates a PR or issue that requires discussion label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/discuss Indicates a PR or issue that requires discussion
Projects
None yet
Development

No branches or pull requests

1 participant