Patching status triggers new reconciliation loop #54
Labels
kind/bug
Categorizes issue or PR as related to a bug.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Currently, several of our controllers (originally identified in the Task controller) don't filter status field updates resulting in status patches triggering additional reconciliation requests. This behavior is actually relied upon by a task controller but feels very incidental as opposed to intentional.
We should refactor to filter for status field updates and explicitly issue a requeue if that's the desired behavior. This will create code that's much clearer in its intent.
The
GenerationChangedPredicate
can be applied to theFor(...)
method when registering with the controller manager. This ensures we associate the predicate with a single type in the event more types are listened to such as the job controller.The text was updated successfully, but these errors were encountered: