Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISO] fast fail for invalid -iso-url #561

Open
jacobweinstock opened this issue Nov 23, 2024 · 0 comments
Open

[ISO] fast fail for invalid -iso-url #561

jacobweinstock opened this issue Nov 23, 2024 · 0 comments

Comments

@jacobweinstock
Copy link
Member

We should consider panicking if the -iso-url value is invalid. Currently, it's not until a request is made against the ISO endpoint that the logs indicate that the URL is not valid. The extent of what we check to determine validity is up for debate.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

@jacobweinstock jacobweinstock changed the title [ISO] fast fail of back -iso-url [ISO] fast fail for invalid -iso-url Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant