-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not respecting standards file #40
Comments
Did you point to the file directly viat action-php-codesniffer/action.yml Line 17 in 4a0895c
Can you copy your workflow file here? |
Yes, I have: - uses: tinovyatkin/action-php-codesniffer@v1
with:
files: "**.php" # you may customize glob as needed
phpcs_path: php phpcs.phar
standard: phpcs.xml It is an exact copy of the readme. |
I set up an example repo. See lode/phpcs-action-test#1. It makes remarks about things outside my standards, and the things inside the standards, like |
Confirmed that it indeed ignores the |
Since author hasn't merged the code yet, I have fixed and published my own fork of it. |
@thenabeel thanks for the fork! Looking forward to merging the code as I am experiencing same issue. |
@elenakondrateva I just saw your comment, haha pretty late. I hope it was helpful for you. |
I have an action setup exactly as in the readme (https://github.com/tinovyatkin/action-php-codesniffer#usage), and have a
phpcs.xml
in the root of the repository which looks alike this:I'm including a few specific rules and no generic standard. However, I get annotations referring to
Generic.Files.LineLength.TooLong
andPEAR.WhiteSpace.ScopeIndent.Incorrect
and others which I didn't include.It seems thus as if my standards file is not respected/recognized and a default standard is used. Does anyone know what's going on?
The text was updated successfully, but these errors were encountered: