Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hover descriptions on constants #8

Open
tirix opened this issue Mar 6, 2022 · 1 comment
Open

Wrong hover descriptions on constants #8

tirix opened this issue Mar 6, 2022 · 1 comment

Comments

@tirix
Copy link
Owner

tirix commented Mar 6, 2022

In general, the correct description is provided when hovering over constants:
image

However, in some cases, there is a shift between the correct description and the description shown:
image

Here, the correct description for /\ would be: Wedge (read: 'and')
But the description shown is: Vee (read: 'or')

@tirix
Copy link
Owner Author

tirix commented Mar 6, 2022

The reason is that metamath-knife expects the comment for a given statement just before that statement, as it is systematically the case for all axioms and theorems. However in the case of many constant declarations (but not all), it is provided just after them.

Obviously there is a more general question here, about whether we shall have a strict formatting for comments associated to $c constant declarations, or implement a kind of empirical rule (like, "if a comment follows on the same line, it is the associated comment").

I don't expect this issue to be fixed quickly, and there will probably no change to be done on the Visual Studio Code extension or LSP server, but I wanted to track it anyway since it will probably raise questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant