Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee review #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Employee review #1

wants to merge 2 commits into from

Conversation

Tmidge
Copy link

@Tmidge Tmidge commented Jan 27, 2015

Forgot to fork :( hope that didnt mess up everything.

return salaries
end

def department_raise(dollars)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the loop to accumulate the salary over which raises will be given, then a second loop to distribute. It might be a bit cleaner to break this into multiple methods, but it's very good logic.

@masonfmatthews
Copy link
Contributor

Good work, Thomas. You're doing well. Comments are just minor thoughts to improve your style over time.

@Tmidge
Copy link
Author

Tmidge commented Jan 28, 2015

Oh wow, I didn't even notice my hard mode didn't upload! when I had to copy
everything over when I forgot to fork I guess it got lost.

On Wed, Jan 28, 2015 at 6:01 AM, Mason F. Matthews <[email protected]

wrote:

Good work, Thomas. You're doing well. Comments are just minor thoughts to
improve your style over time.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@Tmidge
Copy link
Author

Tmidge commented Jan 28, 2015

Hard mode found and sent.

On Wed, Jan 28, 2015 at 6:01 AM, Mason F. Matthews <[email protected]

wrote:

Good work, Thomas. You're doing well. Comments are just minor thoughts to
improve your style over time.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants