Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee Reviews #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

jesseract
Copy link

I did this one mostly by myself AND finished before midnight! Booyow!


def salary_list
sum = 0
@employees.each { |employee| sum += employee.salary }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good logic. Recall that you could also do lines 20 and 21 together in a reduce call.

@masonfmatthews
Copy link
Contributor

Jess - awesome work. I made a few minor comments, but just to give you ideas for the future, not because you got anything wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants