Remove redis from dependencies

[daveisfera]

Currently, redis has to be installed even if it's not used. It shouldn't be included in dependencies so ioredis can be used without having to install redis

[knoxcard]

https://github.com/tj/connect-redis/blob/master/lib/connect-redis.js

var redis = require('redis')

    // convert to redis connect params
    if (options.client) {
      this.client = options.client;
    } else {
      var redis = require('redis');

      if (options.socket) {
        this.client = redis.createClient(options.socket, options);
      }
      else {
        this.client = redis.createClient(options);
      }
    }

Hmm, so it seems that redis is the default if nothing is specified. I see your point!

[knoxcard]

@wavded - what should be done here?

[daveisfera]

peerDependencies are a common way to deal with this, but I don't believe that they allow specifying "either or" types of relationships:
https://docs.npmjs.com/files/package.json#peerdependencies

[knoxcard]

@daveisfera - peerDependencies, that looks like the solution to me right there!

[daveisfera]

It's probably the best option right now, because peerDependencies would prevent redis from being installed when it's not needed, but would result in a warning that it's not installed until there's support for specifying an or for multiple packages to satisfy the requirement.

See the following:
https://npm.community/t/allow-any-one-of-specified-packages-in-peerdependencies/4933
duaraghav8/solium-plugin-security#33

[wavded]

This would be a breaking change and require a major version update, seems pretty minor if its included but not used to me. We did recently update it to not include the files in the runtime if not used as well. The vast majority of people use the main redis package.

[daveisfera]

I agree that it would be a breaking change, but it results in 4 packages being installed and that takes up almost 400KB, so it would be great to not have to include it when we use it.

[wavded]

We no longer bundle a Redis client in V4.

[daveisfera]

Thanks!

[knoxcard]

Sweeet!!!