Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mustache support is broken since mustache v4 release #331

Closed
vladimyr opened this issue Feb 18, 2020 · 4 comments · Fixed by #332
Closed

Mustache support is broken since mustache v4 release #331

vladimyr opened this issue Feb 18, 2020 · 4 comments · Fixed by #332

Comments

@vladimyr
Copy link
Contributor

⚠️ consolidate internally uses mustache.to_html() (source) that got removed in v4: https://github.com/janl/mustache.js/blob/aca97b8/CHANGELOG.md#400--16-january-2020

Original to_html implementation can be seen here:
https://github.com/janl/mustache.js/pull/735/files#diff-634d226b45dfff37e6e48538dbfe4cb0L730-L742
which clearly indicates that it can be safely replaced with mustache.render call.

Reading through issues I got under impression that this package is effectively unmaintained (#292) but if you have any free time I believe this is something that needs your (immediate) attention @doowb
@vladimyr vladimyr mentioned this issue Feb 18, 2020
Merged
@doowb
Copy link
Collaborator

doowb commented Feb 18, 2020

PRs are welcome.

@vladimyr vladimyr mentioned this issue Feb 18, 2020
Merged
@vladimyr
Copy link
Contributor Author

Hopefully it will get published to npm soon 🤞

@alemangui
Copy link

Hey there, any news on a release containing this fix anytime soon?

@alemangui alemangui mentioned this issue Jul 21, 2020
Closed
@vladimyr
Copy link
Contributor Author

Hey there, any news on a release containing this fix anytime soon?

Join the waiting party 🥳
The last release was 2yrs ago: https://github.com/tj/consolidate.js/releases/tag/0.15.1 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mustache support vladimyr/consolidate.js
3 participants
@doowb @vladimyr @alemangui