Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering Templates from buffers #340

Open
Haringat opened this issue Nov 19, 2021 · 6 comments
Open

Support rendering Templates from buffers #340

Haringat opened this issue Nov 19, 2021 · 6 comments

Comments

@Haringat
Copy link

Right now consolidate only supports taking a path in the file system which it is supposed to render. However, it would be good to support rendering a template in a buffer so that the template can be stored e.g. in a database and the service does not have to be redeployed for every change in the templates.

@niftylettuce
Copy link
Collaborator

PR welcome

@titanism
Copy link

titanism commented Jun 8, 2023

We have forked this repository for maintenance and released it under @ladjs/consolidate, see https://github.com/ladjs/consolidate.js. We have merged PR's and updated it for email-templates. Please click the "Watch" button to get notified of all releases at https://github.com/ladjs/consolidate.js. Thank you 🙏

Screen Shot 2023-06-08 at 3 05 12 PM

PR welcome at the new repo once new release is published today!

@Haringat
Copy link
Author

Haringat commented Jun 8, 2023

@titanism are you aware that spamming goes against GitHub's ToS? And spamming personal promotion under every issue of someone else's repo is ethically questionable to say the least... Especially for issues you may not even have solved. One could easily find your fork in the network next to the fork button.

@titanism
Copy link

titanism commented Jun 8, 2023

Hi @Haringat - we are the original maintainers and have npm access as well.

https://www.npmjs.com/package/consolidate

@titanism
Copy link

titanism commented Jun 8, 2023

FYI we will be publishing on both consolidate npm and @ladjs/consolidate as similar that we did for koa-router and @koa/router.

@titanism
Copy link

titanism commented Jun 9, 2023

v1.0.0 of consolidate has been released (and mirrored to @ladjs/consolidate) 🎉

watch/follow https://github.com/ladjs/consolidate for updates and to submit future issues and PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants