Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix datetime extraction #226

Merged
merged 10 commits into from
Apr 22, 2024
Merged

fix: Fix datetime extraction #226

merged 10 commits into from
Apr 22, 2024

Conversation

tlambert03
Copy link
Owner

This PR fixes datetime extraction by not using text_info, and instead, casting the jdn time in the global metadata to the local timezone.

closes #221
closes #225

@tlambert03 tlambert03 mentioned this pull request Apr 21, 2024
Copy link

codspeed-hq bot commented Apr 21, 2024

CodSpeed Performance Report

Merging #226 will not alter performance

Comparing fix-time (daf34e8) with main (0a46b98)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 changed the title Fix datetime extraction fix: Fix datetime extraction Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.27%. Comparing base (0a46b98) to head (daf34e8).

Files Patch % Lines
src/nd2/_util.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   95.19%   95.27%   +0.07%     
==========================================
  Files          18       18              
  Lines        2436     2433       -3     
==========================================
- Hits         2319     2318       -1     
+ Misses        117      115       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit c1848a3 into main Apr 22, 2024
23 checks passed
@tlambert03 tlambert03 deleted the fix-time branch April 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with saving nd2 to ome-tiff
1 participant