fix(infra): memory leak

packages/common/infra/src/framework/core/event.ts

@@ -48,16 +48,16 @@ export class EventBus {
     this.listeners[event.id].push(listener);
     const off = this.parent?.on(event, listener);
     return () => {
-      this.off(event, listener);
       off?.();
+      this.off(event.id, listener);
     };
   }
 
-  off<T>(event: FrameworkEvent<T>, listener: (event: T) => void) {
-    if (!this.listeners[event.id]) {
+  private off(eventId: string, listener: (event: any) => void) {
+    if (!this.listeners[eventId]) {
       return;
     }
-    this.listeners[event.id] = this.listeners[event.id].filter(
+    this.listeners[eventId] = this.listeners[eventId].filter(
       l => l !== listener
     );
   }
@@ -76,6 +76,15 @@ export class EventBus {
       }
     });
   }
+
+  dispose(): void {
+    for (const eventId of Object.keys(this.listeners)) {
+      for (const listener of this.listeners[eventId]) {
+        this.parent?.off(eventId, listener);
+      }
+    }
+    this.listeners = {};
+  }
 }
 
 interface EventHandler {

packages/common/infra/src/framework/core/provider.ts

@@ -130,6 +130,7 @@ export class ComponentCachePool {
         }
       }
     }
+    this.cache.clear();
   }
 
   [Symbol.dispose]() {
@@ -318,5 +319,6 @@ export class BasicFrameworkProvider extends FrameworkProvider {
     }
     this.disposed = true;
     this.cache.dispose();
+    this.eventBus.dispose();
   }
 }

packages/common/infra/src/modules/workspace/entities/workspace.ts

@@ -82,4 +82,9 @@ export class Workspace extends Entity {
     }),
     undefined
   );
+
+  override dispose(): void {
+    this.docCollection.awarenessStore.destroy();
+    (this.docCollection.awarenessStore.awareness as Awareness).destroy();
+  }
 }

packages/common/infra/src/modules/workspace/services/repo.ts

@@ -49,7 +49,7 @@ export class WorkspaceRepositoryService extends Service {
       return {
         workspace,
         dispose: () => {
-          workspace.dispose();
+          workspace.scope.dispose();
         },
       };
     }

packages/common/infra/src/modules/workspace/services/workspace.ts

@@ -10,4 +10,8 @@ export class WorkspaceService extends Service {
     }
     return this._workspace;
   }
+
+  override dispose(): void {
+    this._workspace?.dispose();
+  }
 }

packages/common/infra/src/modules/workspace/testing/testing-provider.ts

@@ -94,6 +94,8 @@ class TestingWorkspaceLocalProvider implements WorkspaceFlavourProvider {
 
     applyUpdate(bs.doc, data);
 
+    bs.awarenessStore.awareness.destroy();
+
     return {
       name: bs.meta.name,
       avatar: bs.meta.avatar,

packages/common/infra/src/sync/awareness.ts

@@ -7,7 +7,9 @@ export interface AwarenessConnection {
 }
 
 export class AwarenessEngine {
-  constructor(public readonly connections: AwarenessConnection[]) {}
+  constructor(public readonly connections: AwarenessConnection[]) {
+    console.log('AwarenessEngine', connections);
+  }
 
   connect(awareness: Awareness) {
     this.connections.forEach(connection => connection.connect(awareness));

packages/frontend/core/src/blocksuite/presets/_common/utils/markdown-utils.ts

@@ -194,6 +194,7 @@ export async function markDownToDoc(
   const collection = new DocCollection({
     schema,
   });
+  collection.awarenessStore.awareness.destroy();
   collection.meta.initialize();
   const middlewares = [defaultImageProxyMiddleware];
   if (additionalMiddlewares) {

packages/frontend/core/src/mobile/components/workspace-selector/menu.tsx

@@ -61,7 +61,7 @@ const WorkspaceList = ({
   const toggleWorkspace = useCallback(
     (id: string) => {
       if (id !== currentWorkspace.id) {
-        jumpToPage(id, 'all');
+        jumpToPage(id, 'home');
       }
       onClose?.();
     },

packages/frontend/core/src/modules/docs-search/entities/docs-indexer.ts

@@ -85,24 +85,26 @@ export class DocsIndexer extends Entity {
   }
 
   setupListener() {
-    this.workspaceEngine.doc.storage.eventBus.on(event => {
-      if (WorkspaceDBService.isDBDocId(event.docId)) {
-        // skip db doc
-        return;
-      }
-      if (event.clientId === this.workspaceEngine.doc.clientId) {
-        this.jobQueue
-          .enqueue([
-            {
-              batchKey: event.docId,
-              payload: { storageDocId: event.docId },
-            },
-          ])
-          .catch(err => {
-            console.error('Error enqueueing job', err);
-          });
-      }
-    });
+    this.disposables.push(
+      this.workspaceEngine.doc.storage.eventBus.on(event => {
+        if (WorkspaceDBService.isDBDocId(event.docId)) {
+          // skip db doc
+          return;
+        }
+        if (event.clientId === this.workspaceEngine.doc.clientId) {
+          this.jobQueue
+            .enqueue([
+              {
+                batchKey: event.docId,
+                payload: { storageDocId: event.docId },
+              },
+            ])
+            .catch(err => {
+              console.error('Error enqueueing job', err);
+            });
+        }
+      })
+    );
   }
 
   async execJob(jobs: Job<IndexerJobPayload>[], signal: AbortSignal) {
@@ -298,6 +300,8 @@ export class DocsIndexer extends Entity {
   }
 
   override dispose(): void {
+    super.dispose();
     this.runner.stop();
+    this.worker?.dispose();
   }
 }

packages/frontend/core/src/modules/docs-search/worker/out-worker.ts

@@ -95,8 +95,8 @@ export async function createWorker(abort: AbortSignal) {
       });
     },
     dispose: () => {
-      worker.terminate();
       terminateAbort.abort(MANUALLY_STOP);
+      worker.terminate();
     },
   };
 }

packages/frontend/core/src/modules/workspace-engine/impls/cloud.ts

@@ -240,6 +240,7 @@ class CloudWorkspaceFlavourProvider implements WorkspaceFlavourProvider {
       id,
       schema: getAFFiNEWorkspaceSchema(),
     });
+    bs.awarenessStore.awareness.destroy();
 
     if (localData) applyUpdate(bs.doc, localData);
     if (cloudData) applyUpdate(bs.doc, cloudData.data);

packages/frontend/core/src/modules/workspace-engine/impls/local.ts

@@ -162,6 +162,7 @@ class LocalWorkspaceFlavourProvider implements WorkspaceFlavourProvider {
       id,
       schema: getAFFiNEWorkspaceSchema(),
     });
+    bs.awarenessStore.awareness.destroy();
 
     if (localData) applyUpdate(bs.doc, localData);