Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: namedTags.includes is not a function #1

Open
ichiriac opened this issue Dec 9, 2016 · 3 comments
Open

TypeError: namedTags.includes is not a function #1

ichiriac opened this issue Dec 9, 2016 · 3 comments

Comments

@ichiriac
Copy link

ichiriac commented Dec 9, 2016

Hi @shannonmoeller

I have the following error message :

     TypeError: namedTags.includes is not a function
      at parseTag (node_modules/tunic/dist/tunic.js:198:39)
      at node_modules/tunic/dist/tunic.js:158:11
      at Array.map (native)
      at parseComment (node_modules/tunic/dist/tunic.js:157:14)
      at parseBlocks (node_modules/tunic/dist/tunic.js:121:21)
      at Object.parse (node_modules/tunic/dist/tunic.js:99:11)`

To reproduce the bug :

var tunic = require('tunic'); // @version 2.0.0
tunic.parse('/**\n             * @var bar\n             */');

Am I missing something ?

@ichiriac
Copy link
Author

ichiriac commented Dec 9, 2016

found why here : nodejs/node#5715

my nodejs version is V8 4.2

You could use indexOf instead to make the code more compatible, or run node with --harmony_array_includes flag

@shannonmoeller
Copy link
Member

You are correct. That has been changed to indexOf in newer code, but that code isn't ready for a release. I'll see about fixing that. Thanks!

@ichiriac
Copy link
Author

ichiriac commented Dec 9, 2016

thanks @shannonmoeller, meanwhile I will fork and make a fix commit in order to use it with npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants