Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.39.0 breaks quinn: linked_list.rs panic #6714

Closed
alexheretic opened this issue Jul 23, 2024 · 2 comments · Fixed by #6715
Closed

1.39.0 breaks quinn: linked_list.rs panic #6714

alexheretic opened this issue Jul 23, 2024 · 2 comments · Fixed by #6715
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-time Module: tokio/time

Comments

@alexheretic
Copy link
Contributor

alexheretic commented Jul 23, 2024

Version 1.39.0

Platform
Linux alex-XPS-15-9520 6.5.0-44-generic #44~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jun 18 14:36:16 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Description
tokio 1.39.0 causes quinn to panic. Repro running quinn tests. See quinn-rs/quinn#1936

thread 'tests::stream_id_flow_control' panicked at /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.0/src/util/linked_list.rs:123:9:
assertion `left != right` failed
  left: Some(0x7405e001cca8)
 right: Some(0x7405e001cca8)

As suggested by @Darksonn reverting #6584 fixes the issue.

@alexheretic alexheretic added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Jul 23, 2024
@Darksonn Darksonn added the M-time Module: tokio/time label Jul 23, 2024
@Darksonn
Copy link
Contributor

Thank you. We will be reverting this change for 1.39.1.

Afterwards, we can try to determine what the bug is and re-land the change for 1.40.0.

@fasterthanlime
Copy link
Contributor

fasterthanlime commented Jul 23, 2024

Amazingly, I have spent days debugging this, believing that my terrible, no-good shared object hacks were causing memory corruption.

...but I was running a patched tokio, forked from well after #6584 was merged.

So chances are, I've been chasing a ghost this whole time.

Ah well, at least there's pretty colors now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-time Module: tokio/time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants