Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeWriterExt docs fix #2831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MakeWriterExt docs fix #2831

wants to merge 1 commit into from

Conversation

kaffarell
Copy link
Contributor

Fixes #2819

@kaffarell kaffarell requested review from hawkw and a team as code owners December 10, 2023 11:49
@mladedav
Copy link
Contributor

Should this target master instead of v0.1.x? I assume the issue will be there too and backporting should be simple since the context will be the same in the changed file?

@kaffarell kaffarell changed the base branch from v0.1.x to master May 22, 2024 09:22
@kaffarell kaffarell force-pushed the make_writer_docs_fix branch from 46f6507 to 60eaef8 Compare May 22, 2024 09:39
@kaffarell kaffarell force-pushed the make_writer_docs_fix branch from 60eaef8 to e852c4b Compare May 22, 2024 09:41
@kaffarell
Copy link
Contributor Author

Oops, yes. Fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mladedav mladedav mladedav approved these changes

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

@yaahc yaahc Awaiting requested review from yaahc

@carllerche carllerche Awaiting requested review from carllerche

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion when reading doc examples for MakeWriterExt in tracing-subscriber
2 participants
@kaffarell @mladedav