pull-request-notifier-for-bitbucket lock threads on Bitbucket

[gerjesjo]

If things don't work as you expect, perhaps you should file an issue. But first, try troubleshooting it and provide as much info as possible. Here are some things that may help if added to an issue.

• Plugin version used : 3.22
• Bitbucket Server version used : 5.11
• Stack traces in Bitbucket Server log file : Attached

From thread dumps was that the Pull request notifier for Bitbucket plugin was holding the lock while performing its operations and parking everything else waiting for that to finish.

we can see the se.bjurr.prnfb.service.SettingsService.doGetPrnfbSettings executing the stack. Further down on that stack I could also see the following:
{code}
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
at org.eclipse.gemini.blueprint.service.importer.support.internal.aop.ServiceInvoker.doInvoke(ServiceInvoker.java:56)
at org.eclipse.gemini.blueprint.service.importer.support.internal.aop.ServiceInvoker.invoke(ServiceInvoker.java:60)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:133)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:121)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.eclipse.gemini.blueprint.service.util.internal.aop.ServiceTCCLInterceptor.invokeUnprivileged(ServiceTCCLInterceptor.java:70)
at org.eclipse.gemini.blueprint.service.util.internal.aop.ServiceTCCLInterceptor.invoke(ServiceTCCLInterceptor.java:53)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.eclipse.gemini.blueprint.service.importer.support.LocalBundleContextAdvice.invoke(LocalBundleContextAdvice.java:57)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.doProceed(DelegatingIntroductionInterceptor.java:133)
at org.springframework.aop.support.DelegatingIntroductionInterceptor.invoke(DelegatingIntroductionInterceptor.java:121)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:213)
at com.sun.proxy.$Proxy888.execute(Unknown Source)
at se.bjurr.prnfb.service.SettingsService$7.perform(SettingsService.java:344)
at com.atlassian.stash.internal.user.DefaultEscalatedSecurityContext.call(DefaultEscalatedSecurityContext.java:58)
at se.bjurr.prnfb.service.SettingsService.inSynchronizedTransaction(SettingsService.java:340)

• locked [0x00000005cf631e38] (a se.bjurr.prnfb.service.SettingsService)
  at se.bjurr.prnfb.service.SettingsService.getPrnfbSettings(SettingsService.java:185)
  at se.bjurr.prnfb.service.SettingsService.findButton(SettingsService.java:108)
  at se.bjurr.prnfb.service.SettingsService.getButton(SettingsService.java:116)
  at se.bjurr.prnfb.service.ButtonsService.doGetButtons(ButtonsService.java:58)
  at se.bjurr.prnfb.service.ButtonsService.getButtons(ButtonsService.java:130)
  at se.bjurr.prnfb.presentation.ButtonServlet.get(ButtonServlet.java:153)
  {code}
  Where we can see the lock locked [0x00000005cf631e38] (a se.bjurr.prnfb.service.SettingsService) which is exactly the lock on monitor holding everything.