-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setBubble sometimes not working in Chrome #96
Comments
Seems like this project is abandoned, but I am having similar issues. For me it is related to:
If I remove this, then it works fine. |
Fix is to use this PR: #97 but fix the typo :) |
Here's a fixed minified version: |
@adrianbj thanks for the fix. This was driving me nuts as I could call setBubble in the console and have it work fine. But was the first "icon" link found. However unlike a real icon link there is no type. icon and things worked. Also changing to match(/^icon$/) from /\bicon\b/ seemed to solve the issue as well. |
I've used a breakpoint in Chrome (v65) developer tools to verify that setBubble is being called when loading the following page:
https://staging.my.siyli.org
But when the icon shows up it doesn't have the badge. (During the breakpoint Chrome shows its spinner instead of the icon so I can't tell for sure if the icon gets badged and then unbadged.)
I can then go in to the Console and run
Tinycon.setBubble("S")
and the badge shows up.In Firefox the icon is getting badged correctly, and in Safari the title changes to include "(S)".
Confusingly, the badge works fine in Chrome when I am in local development (accessing my app on localhost:3000).
It feels like maybe something in Chrome is resetting the favicon after setBubble is called, but I can't figure out how to find where that would be. Can anyone take a look at the URL above and tell what's going on?
The text was updated successfully, but these errors were encountered: