Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Fee Formula on website #13

Open
vegancat opened this issue Sep 27, 2022 · 0 comments
Open

Incorrect Fee Formula on website #13

vegancat opened this issue Sep 27, 2022 · 0 comments

Comments

@vegancat
Copy link

Bug Type

UI

Reproduction steps

  1. Open the Bridge website
  2. Incorrect Formula in Bridge fee

Screenshot 2022-09-27 125114

Actual result

It show's Formula below as the formula for Bridge fee:5 TON + 0.25% of amount

An example:

Assume we have 100 as Ton amount. according to Formula Bridge fee should be:
5 + 0.25% * 100 = 5 + 0.25 = 5.25

But the Fee on the screen is 5.2375
image

Expected result

Looking at the codebase and calculated fees on the website it's clear that the correct formula is: 5 TON + 0.25% of (amount - 5 )

Following our example in "Actual Result" we would have:

Ton amount = 100

Bridge Fee = 5 + (0.25% * (100 - 5) = 5 + 0.2375 = 5.2375

Suggested Severity

High

Device

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version win11 21h2

Additional Context

No response

vegancat added a commit to vegancat/bridge that referenced this issue Oct 7, 2022
As discussed in issue ton-blockchain#13, the current formula is not correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant