You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed a discrepancy in the TVM whitepaper regarding the serialization instruction for the opcode F4A6_. The current text states that "the instruction can be obtained by first serializing F4A8," which appears to be an error.
Upon reviewing the binary representation, F4A6 in binary is 11110100101001. It's not possible to append bits to this sequence to form F4A8, as the latter would require a different binary pattern. Instead, the correct subsequent serialization that matches the expected pattern is 1111010010100100, which corresponds to F4A4.
I have conducted experiments and confirmed that the compiled FIFT code for the contract indeed results in the opcode F4A4, not F4A8. This change is crucial for maintaining the accuracy and consistency of the whitepaper with the actual behavior of the TVM.
Proposed Changes:
Change "instruction can be obtained by first serializing F4A8" to "instruction can be obtained by first serializing F4A4" in the TVM whitepaper.
This adjustment will ensure that the documentation accurately reflects the serialization process and avoids any confusion for developers working with the TVM.
Additional Notes:
I have attached the binary representations and the results of my experiments as proof of this correction.
I recommend a review of related sections in the whitepaper to ensure there are no other discrepancies that may have been overlooked.
Thank you for considering this important update. I believe it will greatly benefit the community by providing a more reliable and accurate resource.
Best regards,
The text was updated successfully, but these errors were encountered:
zqy-691001
changed the title
Update TVM Whitepaper: Correct Serialization Instruction for F4A6
Update TVM Whitepaper: Correct Serialization Instruction for F4A6_
Oct 30, 2024
Hello Team,
I've noticed a discrepancy in the TVM whitepaper regarding the serialization instruction for the opcode F4A6_. The current text states that "the instruction can be obtained by first serializing F4A8," which appears to be an error.
Upon reviewing the binary representation, F4A6 in binary is
11110100101001
. It's not possible to append bits to this sequence to form F4A8, as the latter would require a different binary pattern. Instead, the correct subsequent serialization that matches the expected pattern is1111010010100100
, which corresponds to F4A4.I have conducted experiments and confirmed that the compiled FIFT code for the contract indeed results in the opcode F4A4, not F4A8. This change is crucial for maintaining the accuracy and consistency of the whitepaper with the actual behavior of the TVM.
Proposed Changes:
This adjustment will ensure that the documentation accurately reflects the serialization process and avoids any confusion for developers working with the TVM.
Additional Notes:
Thank you for considering this important update. I believe it will greatly benefit the community by providing a more reliable and accurate resource.
Best regards,
The text was updated successfully, but these errors were encountered: