Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask Templates XSS Vulnerabilities #112

Open
tonybaloney opened this issue May 16, 2020 · 4 comments
Open

Flask Templates XSS Vulnerabilities #112

tonybaloney opened this issue May 16, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tonybaloney
Copy link
Owner

Investigate and add support for techniques for Cross-Site-Scripting in Flask Templates.

Because Flask uses Jinja2, its likely that the existing Jinja inspections will work

@tonybaloney tonybaloney added enhancement New feature or request help wanted Extra attention is needed labels May 16, 2020
@backtrack-5
Copy link

Dear @tonybaloney, I just created a flask application with XSS vulnerability to test this plugin. Unfortunately when i tried to install the plugin Pycharm i am getting "Plugin 'Pycharm Security' is incompatible with this installation". Are there any specific version of Pycharm should i use ? I am using Pycharm Community 2018.2

image

Thank you,
Sornalingam

@tonybaloney
Copy link
Owner Author

You need either 2019.3 or 2020.1+, the plugin uses APIs in those versions

@backtrack-5
Copy link

@tonybaloney , Thanks for your clarification. I am trying to do the following things,

  1. Create flask application with XSS vulnerability --> Done
  2. Install Pycharm-security ->inprogress
  3. Test your application with the plugin and see the suggestion

Can you please tell me whether the above items are fine or do we need to consider any other things ?

@backtrack-5
Copy link

backtrack-5 commented Jul 18, 2020

@tonybaloney , Sorry for the delayed response.

I have imported the plugin and tried with SSTI and when i executed the inspection i did not get correct warning from the plugin

image

Input from browser

image

Test case:

  1. Line no 9 in my code - it has XSS vulnerable.

Expected result

  1. Plugin should find and give warn this use case

Actual result:

  1. I did not get any warning for this scenario from plugin

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants