Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[epic] Refactoring & Make Code Climate happy #22

Open
1 of 4 tasks
zhuyifei1999 opened this issue May 3, 2016 · 0 comments
Open
1 of 4 tasks

[epic] Refactoring & Make Code Climate happy #22

zhuyifei1999 opened this issue May 3, 2016 · 0 comments

Comments

@zhuyifei1999
Copy link
Member

zhuyifei1999 commented May 3, 2016 •
edited
Loading

Code Climate

  • Simplify duplicated code
  • Simplify call parameters
  • Make parts packages
  • Unit testing
zhuyifei1999 added a commit that referenced this issue May 12, 2016
@zhuyifei1999
.codeclimate.yml: ignore everything minified
071d149 
For #22
zhuyifei1999 added a commit that referenced this issue May 12, 2016
@zhuyifei1999
Fix codeclimate configs
2184631 
For #22
@zhuyifei1999 zhuyifei1999 mentioned this issue May 21, 2016
Merged
zhuyifei1999 added a commit that referenced this issue May 21, 2016
@zhuyifei1999
Merge pull request #31 from Toollabs/refactor
13786a5 
Refactor

For #22
@zhuyifei1999 zhuyifei1999 mentioned this issue Jun 7, 2016
Merged
zhuyifei1999 added a commit that referenced this issue Jun 7, 2016
@zhuyifei1999
Merge pull request #40 from Toollabs/js-dup
d83cb10 
Js duplication reduction

For #22
@zhuyifei1999 zhuyifei1999 mentioned this issue Jun 7, 2016
Merged
zhuyifei1999 added a commit that referenced this issue Jun 7, 2016
@zhuyifei1999
Merge pull request #41 from Toollabs/js-dup
b6993ff 
video2commons.js: reduce duplication with statustext generation

For #22
zhuyifei1999 added a commit that referenced this issue Jun 8, 2016
@zhuyifei1999
Merge pull request #43 from Toollabs/frontend-complexity
46dd35c 
Reduce API complexity & duplication

For #22
@zhuyifei1999 zhuyifei1999 mentioned this issue Jun 21, 2016
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhuyifei1999